document: fix cover image in public detailed view #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AoNoOokami
force-pushed
the
zaa-fix-cover-image
branch
from
8826b15 to
2a05d2f
Compare
rerowep
approved these changes
Mar 13, 2020
7 tasks
* Corrects url type filter. * Displays cover as a link for coverImage type. Co-Authored-by: Peter Weber <[email protected]> Co-Authored-by: Alicia Zangger <[email protected]>
AoNoOokami
force-pushed
the
zaa-fix-cover-image
branch
from
2a05d2f to
b6a750a
Compare
jma
approved these changes
Mar 16, 2020
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber [email protected]
Co-Authored-by: Alicia Zangger [email protected]
Why are you opening this PR?
To complete US 1262 https://tree.taiga.io/project/rero21-reroils/us/1262?milestone=257446
How to test?
Covert art(suggested url: https://d2v9ipibika81v.cloudfront.net/uploads/sites/21/Africa-990x684.jpg)Code review check list