tests: fix Zürich timezone problems #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When timezone difference is positive it happens that the we compare an hour superior or equal to 24. In these cases tests on loan/items fails. This commit fixes that and it: * fixes check_timezone_date() using a modulo 24. * displays more info if an error happens in check_timezone_date test * changes get_timezone() description to correspond to reality * fixes a test that compare an UTC date to an non-UTC date Co-Authored-by: Olivier DOSSMANN <[email protected]>
zannkukai
approved these changes
Mar 13, 2020
BadrAly
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When timezone difference is positive it happens that the we compare an
hour superior or equal to 24. In these cases tests on loan/items fails.
This commit fixes that and it:
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
Because tests failed on timezoned date. March, the 20th we will change the timezone from GMT+1 to GMT+2 which displays errors.
How to test?
pipenv run pytest -vvs --no-cov --disable-warnings tests/api/test_items_rest.pyCode review check list