location: adapt JSON schema for pickup_name required if is_pickup #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
fix-location-schema
branch
2 times, most recently
from
6552d3b to
1c11f0a
Compare
zannkukai
requested review from
rerowep,
AoNoOokami,
BadrAly,
blankoworld and
lauren-d
zannkukai
force-pushed
the
fix-location-schema
branch
from
1c11f0a to
6e9de30
Compare
BadrAly
reviewed
Mar 13, 2020
AoNoOokami
approved these changes
Mar 16, 2020
iGormilhit
approved these changes
Mar 16, 2020
zannkukai
force-pushed
the
fix-location-schema
branch
2 times, most recently
from
8826c65 to
27d65bf
Compare
Before this change, the location JSON schema accept that the location was a pickup location (is_pickup=true) but without pickup_name. This fix change this behavior ; when a location is defined as pickup location, then the 'pickup_name' is now required. Note : the schema already contains behavior for the formly editor * Closes rero#794. Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
fix-location-schema
branch
from
27d65bf to
e69162b
Compare
blankoworld
approved these changes
Mar 18, 2020
BadrAly
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the location JSON schema accept that the location was a
pickup location (is_pickup=true) but without pickup_name. This fix change this
behavior ; when a location is defined as pickup location, then the 'pickup_name'
is now required.
Note : the schema already contains behavior for the formly editor
Co-Authored-by: Renaud Michotte [email protected]