installation: fix python packages dependencies #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
requested review from
blankoworld,
iGormilhit,
sebdeleze,
zannkukai,
benerken,
BadrAly,
reropag,
rerowep and
lauren-d
zannkukai
approved these changes
Mar 11, 2020
jma
force-pushed
the
maj-clean-pipfile
branch
2 times, most recently
from
aa862ed to
b6b5378
Compare
blankoworld
suggested changes
Mar 11, 2020
rerowep
approved these changes
Mar 11, 2020
jma
force-pushed
the
maj-clean-pipfile
branch
4 times, most recently
from
018a407 to
2b3cf0c
Compare
BadrAly
approved these changes
Mar 12, 2020
sebdeleze
approved these changes
Mar 12, 2020
blankoworld
suggested changes
Mar 12, 2020
blankoworld
reviewed
Mar 12, 2020
scripts/update
Outdated
|
|
||
| pipenv run invenio alembic upgrade | ||
| pipenv run invenio index init --force | ||
| pipenv run bootstrap |
There was a problem hiding this comment.
As we are already in virtual env, you can run "${script_path}/bootstrap" as previously
blankoworld
approved these changes
Mar 12, 2020
blankoworld
suggested changes
Mar 12, 2020
scripts/update
Outdated
Comment on lines
21
to
22
| script_path=$(dirname "$0") | ||
| ./"$script_path"/bootstrap |
There was a problem hiding this comment.
In my opinion, these lines should be kept. Sorry for the inconvenience 🙏
* Fixes strange behaviours during the resolution dependencies with pipenv. This will make the new python packages easy. * Adds the documentation in the python packages file (Pipefile). * Adds support of a new version of the python import order check tool (isort>=4.3.10). * Adds new bootstrap and server command for pipenv. * Replaces scripts commands by pipenv run: * bootstrap * console * server * setup * update * Adds virtualenv detection in scripts/* for python>3.6.4. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv. This will make the new python packages easy.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Olivier DOSSMANN [email protected]
Note
After the integration into the dev branch the documentation should be updated: https://github.com/rero/rero-ils/blob/master/INSTALL.rst
Why are you opening this PR?
The idea is to make the CI travis tests more stable. Moreover it add the support of python 3.6.10.
How to test?
Code review check list