Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix dependencies and security check #839

Merged
merged 1 commit into from
Mar 10, 2020
Merged

tests: fix dependencies and security check #839

merged 1 commit into from
Mar 10, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Mar 9, 2020 •
edited
Loading

  • Fixes invenio-accounts dependency that causes dependency conflict for
    invenio-celery and invenio-base.
  • Removes useless security exception.
  • Adds security exception due to a bug of a third party tools (pipenv).
  • Add new live_server_scope options in pytest.ini due to the new 1.1.0 version of pytest-flask.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

rerowep
rerowep reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@rerowep rerowep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we have to delete appnope from Pipfile.lock.

@jma jma force-pushed the maj-fix-travis branch 2 times, most recently from 0cb2aa6 to b121981 Compare March 10, 2020 07:11
@jma
tests: fix dependencies and security check
91c4e5a 
* Fixes invenio-accounts dependency that causes dependency conflict for
invenio-celery and invenio-base.
* Removes useless security exception.
* Adds security exception due to a bug of a third party tools (pipenv).
* Add new `live_server_scope` options in pytest.ini due to the new 1.1.0 version of pytest-flask.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the maj-fix-travis branch from b121981 to 91c4e5a Compare March 10, 2020 08:36
@jma jma merged commit 2f96ab2 into rero:dev Mar 10, 2020
@jma jma deleted the maj-fix-travis branch April 10, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@rerowep rerowep Awaiting requested review from rerowep

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @blankoworld @zannkukai @rerowep