tests: fix problems with daylight saving time #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
reviewed
Mar 5, 2020
|
|
||
| # should be 14:59/15:59 in US/Pacific (because of daylight saving time) | ||
| check_timezone_date(pytz.timezone('US/Pacific'), loan_date, [14, 15]) | ||
| check_timezone_date(pytz.timezone('Europe/Amsterdam'), loan_date) |
There was a problem hiding this comment.
Why here the expected parameter is not defined as this timezone have also a winter and summer time GMT+1 and GMT+2?
There was a problem hiding this comment.
I consider that Europe/Zurich was so close to Europe/Amsterdam that we can be confident about the result: it would be 1 or 2 hours of difference.
Do you prefer I add them too?
BadrAly
approved these changes
Mar 5, 2020
blankoworld
force-pushed
the
doo-fix-tz-daylight-test
branch
from
ea315fc to
cce783e
Compare
jma
approved these changes
Mar 5, 2020
blankoworld
force-pushed
the
doo-fix-tz-daylight-test
branch
from
cce783e to
a5f1355
Compare
* Fixes test that have problem twice a year with daylight saving time timezone Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
doo-fix-tz-daylight-test
branch
from
a5f1355 to
65eb6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timezone
Co-Authored-by: Olivier DOSSMANN [email protected]
Why are you opening this PR?
To fix problems about timezones in tests.
How to test?
Code review check list