Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring: monitoring for DB and ES #833

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Mar 3, 2020

  • Adds functionality to monitoring values from DB and ES.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

How to test?

after setup:

  • website: localhost:5000/nonitoring/info
  • cli: pipenv run invenio monitoring info

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@rerowep rerowep requested a review from jma March 3, 2020 20:22
@rerowep rerowep self-assigned this Mar 3, 2020
@rerowep rerowep force-pushed the wep-#1342-monitoring branch from 8042895 to c2c3bbb Compare March 4, 2020 14:27
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the view method should be changed. An missing view can be useful if it is limited to the admin user.

@rerowep rerowep force-pushed the wep-#1342-monitoring branch 10 times, most recently from ff2ac02 to c729b95 Compare March 11, 2020 07:18
@iGormilhit iGormilhit self-requested a review March 11, 2020 07:45
@rerowep rerowep force-pushed the wep-#1342-monitoring branch from c729b95 to c56a5b0 Compare March 11, 2020 07:48
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on the commit message:

data: monitor data consistency

* Monitors values consistency between DB and ES, to be warned if records are not indexed.
* Fixes an error occurring during import of MEF records (PID stored in data is not the same as the PID we searched for).

This is a proposition, if you can explain why you're coding this, please do. 🙂

@rerowep rerowep force-pushed the wep-#1342-monitoring branch 4 times, most recently from 31821c1 to fb2dbb8 Compare March 12, 2020 14:53
@rerowep rerowep force-pushed the wep-#1342-monitoring branch 5 times, most recently from 0b551fb to afc09e3 Compare March 16, 2020 09:06
@rerowep rerowep force-pushed the wep-#1342-monitoring branch from afc09e3 to 780460b Compare March 16, 2020 15:08
@rerowep rerowep requested a review from jma March 16, 2020 15:52
@rerowep rerowep force-pushed the wep-#1342-monitoring branch 2 times, most recently from 7052c8c to 8710dda Compare March 17, 2020 11:17
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to update the comments and the documentation. Imagine that you did not write this code. You need to understand the purpose of this code without read it.

@rerowep rerowep force-pushed the wep-#1342-monitoring branch from 8710dda to 169ad00 Compare March 18, 2020 10:54
@rerowep rerowep requested a review from jma March 18, 2020 10:55
@rerowep rerowep force-pushed the wep-#1342-monitoring branch 12 times, most recently from 5fa90b5 to 0272d9b Compare March 23, 2020 15:21
@rerowep rerowep force-pushed the wep-#1342-monitoring branch 2 times, most recently from 5e1f541 to 1fe90ba Compare March 25, 2020 09:42
* Monitors values consistency between DB and ES. Shows missing records
in ES and DB and double indexed records. Helps to monitor the application
and helps to find problems in the application.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1342-monitoring branch from 1fe90ba to e9eda79 Compare March 25, 2020 10:32
@rerowep rerowep merged commit 7d7a8e1 into rero:dev Mar 25, 2020
@rerowep rerowep deleted the wep-#1342-monitoring branch March 26, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants