-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monitoring: monitoring for DB and ES #833
Conversation
8042895
to
c2c3bbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the view method should be changed. An missing view can be useful if it is limited to the admin user.
ff2ac02
to
c729b95
Compare
c729b95
to
c56a5b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only on the commit message:
data: monitor data consistency
* Monitors values consistency between DB and ES, to be warned if records are not indexed.
* Fixes an error occurring during import of MEF records (PID stored in data is not the same as the PID we searched for).
This is a proposition, if you can explain why you're coding this, please do. 🙂
31821c1
to
fb2dbb8
Compare
0b551fb
to
afc09e3
Compare
afc09e3
to
780460b
Compare
7052c8c
to
8710dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to update the comments and the documentation. Imagine that you did not write this code. You need to understand the purpose of this code without read it.
8710dda
to
169ad00
Compare
5fa90b5
to
0272d9b
Compare
5e1f541
to
1fe90ba
Compare
* Monitors values consistency between DB and ES. Shows missing records in ES and DB and double indexed records. Helps to monitor the application and helps to find problems in the application. Co-Authored-by: Peter Weber <[email protected]>
1fe90ba
to
e9eda79
Compare
Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
How to test?
after setup:
Code review check list