Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: update INSTALL.rst #818

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

AoNoOokami
Copy link
Contributor

Why are you opening this PR?

To update documentation on how to install rero-ils

How to test?

N/A

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from f664f00 to b67002e Compare February 28, 2020 15:04
@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from b67002e to a224165 Compare February 28, 2020 15:12
@AoNoOokami AoNoOokami self-assigned this Feb 28, 2020
@AoNoOokami AoNoOokami added the dev: documentation About changelog, release notes, installation procedures, gh templates... label Feb 28, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from a224165 to 532976f Compare February 28, 2020 17:51
@AoNoOokami AoNoOokami requested review from jma and iGormilhit and removed request for jma March 2, 2020 06:55
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit title: documentation: update installation procedure
And this is for the right version of pipenv and python.

@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from 532976f to ed823b1 Compare March 3, 2020 16:01
@AoNoOokami AoNoOokami requested a review from iGormilhit March 3, 2020 16:02
@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from ed823b1 to ed5d283 Compare March 4, 2020 07:13
@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch 3 times, most recently from c1c5e6c to 13c241b Compare March 13, 2020 07:02
* Adds instruction to set the right version of pipenv and python.
Co-Authored-By: Alicia Zangger <[email protected]>
Co-Authored-by: Olivier DOSSMANN <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-update-install-rst branch from 13c241b to 16ed43c Compare March 13, 2020 13:53
@AoNoOokami AoNoOokami merged commit 0908bf9 into rero:dev Mar 13, 2020
@AoNoOokami AoNoOokami deleted the zaa-update-install-rst branch March 18, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: documentation About changelog, release notes, installation procedures, gh templates...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants