Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: $ref from pid #765

Merged
merged 1 commit into from
Mar 5, 2020
Merged

utils: $ref from pid #765

merged 1 commit into from
Mar 5, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 18, 2020

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from 0df372b to b210109 Compare February 18, 2020 12:57
@rerowep rerowep self-assigned this Feb 18, 2020
@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from b210109 to e0add01 Compare February 18, 2020 13:06
@rerowep rerowep requested review from BadrAly and jma February 18, 2020 13:47
@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from e0add01 to 483281c Compare February 18, 2020 14:43
jma
jma requested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message does not follows the guidelines.

@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch 2 times, most recently from bbc6cc9 to c564da5 Compare March 2, 2020 12:26
@rerowep rerowep requested a review from jma March 3, 2020 06:11
@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from c564da5 to eed4309 Compare March 3, 2020 09:21
@jma jma removed their request for review March 3, 2020 11:26
@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from eed4309 to 81574dd Compare March 3, 2020 13:41
@rerowep rerowep requested a review from jma March 4, 2020 15:07
@rerowep
utils: $ref from pid
667280a 
* Adds the possibility to get the $ref from a given pid.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1306-ref-from-pid branch from 81574dd to 667280a Compare March 5, 2020 12:18
@rerowep rerowep merged commit 3a1e846 into rero:dev Mar 5, 2020
@rerowep rerowep deleted the wep-#1306-ref-from-pid branch March 10, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@BadrAly BadrAly BadrAly approved these changes

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerowep @jma @BadrAly