Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: electronicLocator #761

Merged
merged 1 commit into from
Mar 3, 2020
Merged

metadata: electronicLocator #761

merged 1 commit into from
Mar 3, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 17, 2020

  • Adds electronicLocator resource (tag 856).

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

How to test?

  • see in detailed view access and other access links

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 5c130d9 to 2978a07 Compare February 17, 2020 10:42
@rerowep rerowep changed the title metadone: electronicLocator metadata: electronicLocator Feb 17, 2020
@rerowep rerowep requested a review from AoNoOokami February 17, 2020 11:13
@rerowep rerowep added the WIP label Feb 17, 2020
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 2978a07 to 8ee5bc1 Compare February 17, 2020 14:01
AoNoOokami
AoNoOokami reviewed Feb 17, 2020
View reviewed changes
Copy link
Contributor

@AoNoOokami AoNoOokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"publicNote" is displayed in parenthesis after "content" or after the link itself; it is outside of the link

@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch 3 times, most recently from 951555f to 1d68403 Compare February 18, 2020 09:31
@rerowep rerowep removed the WIP label Feb 18, 2020
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 1d68403 to 0f41075 Compare February 18, 2020 10:04
AoNoOokami
AoNoOokami reviewed Feb 18, 2020
View reviewed changes
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch 2 times, most recently from 62c0436 to cb8e595 Compare February 18, 2020 12:41
@rerowep rerowep self-assigned this Feb 18, 2020
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch 6 times, most recently from a55862f to 0055cb8 Compare February 19, 2020 07:01
@rerowep rerowep requested a review from AoNoOokami February 20, 2020 06:14
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch 3 times, most recently from b8bd1f5 to 469555e Compare February 20, 2020 15:16
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 469555e to 384ab9f Compare February 21, 2020 10:17
@AoNoOokami AoNoOokami mentioned this pull request Feb 21, 2020
Merged
7 tasks
@benerken benerken self-requested a review February 26, 2020 07:44
jma
jma requested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see the BNF importation support for this field. I suppose that a similar PR should exists in rero-ils-ui.

@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch 3 times, most recently from 7ae392a to db01a1a Compare March 2, 2020 11:13
@rerowep rerowep requested a review from jma March 2, 2020 11:14
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from db01a1a to 72c7601 Compare March 2, 2020 15:00
@iGormilhit iGormilhit force-pushed the dev branch 2 times, most recently from 8a45982 to 18c7674 Compare March 2, 2020 15:39
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 72c7601 to 94d20cb Compare March 3, 2020 09:19
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 94d20cb to 5bf28c6 Compare March 3, 2020 11:15
@rerowep
metadata: electronicLocator
9f2fe48 
* Adds electronicLocator resource (tag 856).
* Adds detailed debuging option to marc21json cli.
* Fixes detailed view for Identifier.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1300-uniform-resource-locator branch from 5bf28c6 to 9f2fe48 Compare March 3, 2020 13:25
@AoNoOokami AoNoOokami merged commit bb70fbb into rero:dev Mar 3, 2020
@rerowep rerowep deleted the wep-#1300-uniform-resource-locator branch March 4, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld left review comments

@jma jma jma approved these changes

@benerken benerken benerken approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @jma @blankoworld @benerken @AoNoOokami