Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circulation: correct pickup location for actions #749

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Feb 11, 2020

  • Adds current library pid as parameter to apply actions.

Co-Authored-by: Alicia Zangger [email protected]
Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

Corrects 33. of rero/rero-ils-ui#108

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@AoNoOokami AoNoOokami force-pushed the zaa-pickup_location_for_actions branch 4 times, most recently from 41c96cb to 0b7d80d Compare February 12, 2020 09:02
@AoNoOokami AoNoOokami added this to the v0.6.0 milestone Feb 12, 2020
@AoNoOokami AoNoOokami force-pushed the zaa-pickup_location_for_actions branch 3 times, most recently from c398bd4 to 7b3d1af Compare February 12, 2020 09:44
@AoNoOokami AoNoOokami marked this pull request as ready for review February 12, 2020 09:55
@AoNoOokami AoNoOokami force-pushed the zaa-pickup_location_for_actions branch from 7b3d1af to 016f59b Compare February 12, 2020 13:04
* Adds current library pid as parameter to apply actions.

Co-Authored-by: Alicia Zangger <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-pickup_location_for_actions branch from 016f59b to bf980c0 Compare February 12, 2020 13:54
@AoNoOokami AoNoOokami merged commit e49f9a3 into rero:dev Feb 12, 2020
@AoNoOokami AoNoOokami deleted the zaa-pickup_location_for_actions branch February 12, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants