-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation: Flask-Wiki integration #740
Conversation
5f05245
to
953c4a8
Compare
07da878
to
721f40b
Compare
192d887
to
c26d8db
Compare
76747e9
to
2115bf5
Compare
c5947a0
to
98cfa12
Compare
This new module will be used to create the public documentation dedicated to the users and the librarians. * Adds Flask-Wiki dependency. * Adds Flask-Wiki default configuration. * Creates permissions to limit the wiki edition to a dedicated user. * Fixes bootstrap toast js and css to avoid external module collusion. * Moves head.html template code to the main page to be able to overwide the css block. * Includes Flask-Wiki translations. * Removes useless code in the Dockerfile. * Adds specific css for markdown figures. * Creates fixtures for the dev instance and for the tests. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Igor Milhit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your commit message, at the point "How to test ?" , could you please add a word about the "setup" needed after the bootstrap ?
Because without a setup , the new stuff (editor role,...) are not created in the local instance. :-\
Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a test, the language switch (french <-> english) doesn't work.
It stays on the french version.
Any idea ?
Oups, sorry. It is done. |
Yes I works at it supposed to be. If you are in a page without suffixes (_en, _fr, etc.), it will display the page in the language interface if it is exists else the default. You can try it for the documentation root. Only english, french and default exists. The default is the fallback. But in the documentation pages the links are done explicitly in the page language i.e. in the french home page the links contains suffixes thus once you are in the sub pages you cannot switch the language unless the links are changed to default. It is up to the editor. |
This new module will be used to create the public documentation
dedicated to the users and the librarians.
the css block.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Igor Milhit [email protected]
Why are you opening this PR?
How to test?
Code review check list