Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES: fix listeners #738

Merged
merged 1 commit into from
Feb 7, 2020
Merged

ES: fix listeners #738

merged 1 commit into from
Feb 7, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Feb 5, 2020 •
edited
Loading

  • Fixes patron listener for bulk indexing.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • it was not possible to bulk index patrons

How to test?

  • restart server with worker
  • pipenv run utils reindex -t ptrn --yes-i-know
  • pipenv run invenio utils runindex --raise-on-error -c 4 -d
  • verify worker logs

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@blankoworld
Copy link
Contributor

Can you please change listner to listener in commit message?

@rerowep rerowep changed the title ES: fix listners ES: fix listeners Feb 5, 2020
@rerowep rerowep self-assigned this Feb 6, 2020
@Garfield-fr Garfield-fr added this to the v0.6.0 milestone Feb 6, 2020
@rerowep
ES: fix listeners
240b78e 
* Fixes patron listener for bulk indexing.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep requested a review from jma February 6, 2020 16:11
@rerowep rerowep merged commit 5bc39af into rero:dev Feb 7, 2020
@rerowep rerowep deleted the wep-fix-listner branch February 10, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@BadrAly BadrAly BadrAly approved these changes

@blankoworld blankoworld Awaiting requested review from blankoworld

@lauren-d lauren-d Awaiting requested review from lauren-d

@benerken benerken Awaiting requested review from benerken

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rerowep @blankoworld @jma @BadrAly @AoNoOokami @Garfield-fr