Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron_transaction : Adapt PatronTransaction resource #736

Merged
merged 1 commit into from
Feb 12, 2020
Merged

patron_transaction : Adapt PatronTransaction resource #736

merged 1 commit into from
Feb 12, 2020

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Feb 4, 2020 •
edited
Loading

Why are you opening this PR?

  • Adapts PatronTransaction[Event]s resource.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@zannkukai zannkukai requested review from BadrAly, lauren-d and benerken and removed request for BadrAly February 4, 2020 13:34
@zannkukai zannkukai self-assigned this Feb 4, 2020
@zannkukai zannkukai added the WIP label Feb 4, 2020
@zannkukai zannkukai force-pushed the zan-#1290-adapt-patron-transaction branch from a47f2ba to df83574 Compare February 4, 2020 13:47
@BadrAly BadrAly force-pushed the US659 branch 3 times, most recently from dc899a3 to f251c9a Compare February 5, 2020 09:39
@zannkukai zannkukai force-pushed the zan-#1290-adapt-patron-transaction branch from df83574 to 6ef7e6d Compare February 5, 2020 09:54
@zannkukai zannkukai removed the WIP label Feb 5, 2020
@zannkukai zannkukai changed the title PatronTransaction : Adapt PatronTransaction resource patron_transaction : Adapt PatronTransaction resource Feb 5, 2020
@zannkukai
patron_transaction: Adapt schema and ES mapping
1bcad51 
* Adapts JSON schema and ES mapping for PatronTransactions resource.
* Adapts JSON schema and ES mapping for PatronTransactionEvents resource.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai force-pushed the zan-#1290-adapt-patron-transaction branch from 6ef7e6d to 1bcad51 Compare February 5, 2020 12:53
@zannkukai zannkukai merged commit 70b06f2 into rero:US659 Feb 12, 2020
@zannkukai zannkukai deleted the zan-#1290-adapt-patron-transaction branch February 14, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benerken benerken benerken approved these changes

@BadrAly BadrAly BadrAly approved these changes

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees

@zannkukai zannkukai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zannkukai @benerken @BadrAly