acquisition: create invoice resource #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
requested review from
jma,
BadrAly,
zannkukai,
AoNoOokami,
benerken,
blankoworld,
Garfield-fr,
rerowep and
sebdeleze
zannkukai
reviewed
Feb 3, 2020
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Show resolved
Hide resolved
zannkukai
reviewed
Feb 3, 2020
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
from
36c7767 to
e9918e2
Compare
zannkukai
approved these changes
Feb 3, 2020
BadrAly
approved these changes
Feb 4, 2020
sebdeleze
suggested changes
Feb 4, 2020
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
2 times, most recently
from
ed0a605 to
4051f67
Compare
AoNoOokami
approved these changes
Feb 4, 2020
sebdeleze
approved these changes
Feb 5, 2020
blankoworld
reviewed
Feb 6, 2020
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Outdated
Show resolved
Hide resolved
Comment on lines
+30
to
+34
| "title": "Acquisition order line", | ||
| "type": "object", | ||
| "properties": { | ||
| "$ref": { | ||
| "title": "Acquisition order line URI", |
There was a problem hiding this comment.
What do you think about simplifiying with Order line instead of Acquisition order line?
Comment on lines
+41
to
+45
| "title": "Acquisition account", | ||
| "type": "object", | ||
| "properties": { | ||
| "$ref": { | ||
| "title": "Acquisition account URI", |
There was a problem hiding this comment.
Why not just Account? (same thing as previously and for all Acquisition some words to some words everywhere).
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Show resolved
Hide resolved
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Show resolved
Hide resolved
Comment on lines
+75
to
+74
| "ger", | ||
| "spa" |
There was a problem hiding this comment.
Is there no way to list all possible languages? What happens the day where a new vendor is an arabic one? Chinese one? Etc.
| @@ -230,8 +234,11 @@ | |||
| "type": "string", | |||
| "enum": [ | |||
| "CHF", | |||
| "CAD", | |||
There was a problem hiding this comment.
Same as languages: how could we display all known currencies?
benerken
approved these changes
Feb 11, 2020
jma
reviewed
Feb 18, 2020
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Outdated
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
3 times, most recently
from
61ae3f3 to
bb1febe
Compare
benerken
approved these changes
Feb 24, 2020
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
from
bb1febe to
5f0d8de
Compare
jma
approved these changes
Mar 3, 2020
| @@ -55,17 +57,24 @@ class Vendor(IlsRecord): | |||
|
|
|||
| def get_number_of_acq_orders(self): | |||
| """Get number of acq orders.""" | |||
| from ..acq_orders.api import AcqOrdersSearch | |||
There was a problem hiding this comment.
This method can be a class method.
| return AcqOrdersSearch().filter( | ||
| 'term', vendor__pid=self.pid).source().count() | ||
|
|
||
| def get_number_of_acq_invoices(self): |
rero_ils/modules/acq_invoices/jsonschemas/acq_invoices/acq_invoice-v0.0.1.json
Outdated
Show resolved
Hide resolved
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
from
5f0d8de to
92bc265
Compare
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
3 times, most recently
from
101bf53 to
f1f371c
Compare
zannkukai
approved these changes
Mar 20, 2020
* Adds acquisition invoice resource. * Adds a function to check if invoice exists before deleting a vendor. * Adds more currencies to vendors. * Adds fixtures for unit tests. * Updates tests for vendors. Co-Authored-by: Lauren-D <[email protected]>
lauren-d
force-pushed
the
lau-#1245-create-invoice-resource
branch
from
f1f371c to
64d6b58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Lauren-D [email protected]
Why are you opening this PR?
https://tree.taiga.io/project/rero21-reroils/us/1237?milestone=252915
How to test?
There is no way to test backend at this time
Code review check list