Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

person: atomic persons creation and indexation #715

Merged
merged 1 commit into from
Feb 3, 2020
Merged

person: atomic persons creation and indexation #715

merged 1 commit into from
Feb 3, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 27, 2020 •
edited
Loading

  • Adds atomic persons creation.
  • Improves the code for document serializer.
  • Cleans the setup.
  • Adds person bulk indexing to setup.
  • Corrects bulk indexing.

Why are you opening this PR?

How to test?

  • run setup and see if all persons were created

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep self-assigned this Jan 27, 2020
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from b44362d to c8ee36d Compare January 27, 2020 13:05
@rerowep rerowep added the WIP label Jan 27, 2020
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from c8ee36d to f5646ec Compare January 27, 2020 14:28
@rerowep rerowep removed the WIP label Jan 27, 2020
jma
jma reviewed Jan 28, 2020
View reviewed changes
Copy link
Contributor

@jma jma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to your commit message that you have cleaned the serializer implementation?

@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch 2 times, most recently from 9aa79f5 to 84307af Compare January 29, 2020 12:17
@rerowep rerowep requested a review from jma January 30, 2020 08:07
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 84307af to 776b47f Compare January 30, 2020 13:55
@blankoworld
Copy link
Contributor

@rerowep I have author twice in search bar (ie « Stephen »), did you notice the same thing?

The pipenv run setup increases 20% more than previously. Did you also notice that? Is there no other way to reindex persons during the setup?

@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 776b47f to 89b7211 Compare January 31, 2020 07:29
@rerowep
Copy link
Contributor Author

rerowep commented Jan 31, 2020

@rerowep I have author twice in search bar (ie « Stephen »), did you notice the same thing?

The pipenv run setup increases 20% more than previously. Did you also notice that? Is there no other way to reindex persons during the setup?

Indexing will be resolved with: #723

@rerowep rerowep mentioned this pull request Jan 31, 2020
Closed
6 tasks
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 89b7211 to 7ef75ea Compare January 31, 2020 10:58
@rerowep rerowep changed the title person: atomic persons creation person: atomic persons creation and indexation Jan 31, 2020
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch 2 times, most recently from a1b5efc to 5c076d5 Compare January 31, 2020 14:05
@rerowep rerowep requested a review from blankoworld January 31, 2020 14:08
@blankoworld
Copy link
Contributor

Great job! 👍

@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 5c076d5 to 960cdb8 Compare January 31, 2020 15:28
jma
jma approved these changes Feb 3, 2020
View reviewed changes
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 960cdb8 to 3a603cf Compare February 3, 2020 16:26
@rerowep
person: atomic persons creation and indexation
974168d 
* Adds atomic persons creation.
* Improves the code for document serializer.
* Cleans the setup.
* Adds person bulk indexing to setup.
* Corrects bulk indexing.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1271-atomic-persons-creation branch from 3a603cf to 974168d Compare February 3, 2020 20:27
@rerowep rerowep merged commit c5b25a7 into rero:dev Feb 3, 2020
@rerowep rerowep deleted the wep-#1271-atomic-persons-creation branch February 4, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@blankoworld blankoworld blankoworld approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@lauren-d lauren-d lauren-d approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

@benerken benerken Awaiting requested review from benerken

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @blankoworld @jma @AoNoOokami @lauren-d