Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix run-test #702

Merged
merged 1 commit into from
Jan 20, 2020
Merged

tests: fix run-test #702

merged 1 commit into from
Jan 20, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 17, 2020

  • Fixes isort errors.
  • Fixes unused import errors.
  • Fixes item_availability_text test.

Why are you opening this PR?

  • tests failed in dev

How to test?

  • ./run-test.sh

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep added bug bug (critical) Blocking issue, should be fixed ASAP labels Jan 17, 2020
@rerowep rerowep self-assigned this Jan 17, 2020
@rerowep rerowep removed the bug (critical) Blocking issue, should be fixed ASAP label Jan 17, 2020
lauren-d
lauren-d requested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@lauren-d lauren-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_test failed on tests/api/test_items_rest.py

@rerowep
Copy link
Contributor Author

rerowep commented Jan 17, 2020

run_test failed on tests/api/test_items_rest.py

I've seen that the tests on travis did not work, but have you tried it locally?

@rerowep rerowep requested a review from lauren-d January 17, 2020 11:57
blankoworld
blankoworld approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@blankoworld blankoworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the same fix here!
Looks good to me.

@lauren-d
Copy link
Contributor

I've seen that the tests on travis did not work, but have you tried it locally?

locally the tests pass

@rerowep rerowep force-pushed the fix-dev branch 3 times, most recently from 4a70606 to 8ffd60a Compare January 17, 2020 13:34
@rerowep rerowep added the WIP label Jan 17, 2020
@rerowep rerowep force-pushed the fix-dev branch 5 times, most recently from 8ff7280 to 7b7309d Compare January 17, 2020 15:11
@rerowep rerowep removed the WIP label Jan 17, 2020
@rerowep rerowep force-pushed the fix-dev branch 2 times, most recently from 0e28277 to 412b1a9 Compare January 17, 2020 15:20
AoNoOokami
AoNoOokami suggested changes Jan 17, 2020
View reviewed changes
@rerowep rerowep force-pushed the fix-dev branch 4 times, most recently from cfd43b7 to 8ef76af Compare January 20, 2020 09:10
@rerowep rerowep requested a review from AoNoOokami January 20, 2020 09:29
@rerowep
test: fix run-test
d219fc7 
* Corrects problem with pytest 5.3.3
* Corrects problems with isort.
* Corrects problems with item availability test

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep merged commit f61ad51 into rero:dev Jan 20, 2020
@rerowep rerowep deleted the fix-dev branch January 21, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld approved these changes

@zannkukai zannkukai zannkukai approved these changes

@BadrAly BadrAly BadrAly approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@lauren-d lauren-d lauren-d approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@jma jma Awaiting requested review from jma

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@benerken benerken Awaiting requested review from benerken

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rerowep @lauren-d @blankoworld @zannkukai @BadrAly @AoNoOokami