Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment: adaptions for rero-ils-ui #700

Merged
merged 1 commit into from
Jan 23, 2020
Merged

deployment: adaptions for rero-ils-ui #700

merged 1 commit into from
Jan 23, 2020

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 16, 2020 •
edited
Loading

  • Adds rero-ils-ui hash to frontpage.
  • Updates Dockerfile to use of rero-ils-ui package file.

How to test?

  • Frontpage can be tested by changing RERO_ILS_APP_GIT_HASH and RERO_ILS_UI_GIT_HASH in
    config.py
  • real deployment can be tested withminikube or docker-desktop kubernetes and the deployment scripts.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep force-pushed the wep-deployment branch 6 times, most recently from 0cd99d8 to 11f9a50 Compare January 17, 2020 07:47
iGormilhit
iGormilhit approved these changes Jan 21, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From * Updates Dockerfile to use of rero-ils-ui package file. to * Updates Dockerfile to use rero-ils-ui package file.

Otherwise, this PR is ok for me.

@rerowep
deployment: adaptations for rero-ils-ui
53e174c 
* Adds rero-ils-ui hash to frontpage.
* Updates Dockerfile to use rero-ils-ui package file.

Co-Authored-by: Peter Weber <[email protected]>
blankoworld
blankoworld suggested changes Jan 22, 2020
View reviewed changes
Dockerfile Show resolved Hide resolved
@rerowep rerowep merged commit b617e38 into rero:dev Jan 23, 2020
@rerowep rerowep deleted the wep-deployment branch January 27, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankoworld blankoworld blankoworld requested changes

@lauren-d lauren-d lauren-d approved these changes

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@benerken benerken benerken approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rerowep @Garfield-fr @jma @blankoworld @iGormilhit @benerken @AoNoOokami @lauren-d