setup: speed up and clean improvements #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
approved these changes
Jan 16, 2020
rerowep
requested changes
Jan 16, 2020
jma
reviewed
Jan 16, 2020
| @@ -73,3 +73,4 @@ python_version = "3.6" | |||
| test = "python setup.py test" | |||
| build_sphinx = "python setup.py build_sphinx" | |||
| dev = "pytest --no-cov -vs tests" | |||
| setup = "./scripts/setup" | |||
There was a problem hiding this comment.
PIPENV_QUIET=1 ./script/setup instead or better include PIPENV_QUIET=1 in the ./scripts/setup?
There was a problem hiding this comment.
PIPENV_QUIET=1 have an impact on the pipenv command only if used outside the pipenv itself. So before the pipenv run setup or before the script IF it includes pyenv shell inside.
It is to avoid the Courtesy note (Cf. pypa/pipenv#3068). But our pipenv version have a bug on it.
Edit: I will test with pyenv shell inside the scripts/setup file.
There was a problem hiding this comment.
@jma: pyenv shell seems to need more preparation before being usable for this.
❯ ./scripts/setup
pyenv: shell integration not enabled. Run `pyenv init' for instructions.
❯ pyenv init
# Load pyenv automatically by appending
# the following to ~/.zshrc:
eval "$(pyenv init -)"
It remains more comfortable to use the custom shortcut functionnality of pipenv:
- no more preparation for the developer
- a message explains to developer which command to use (if it forget to use
pipenvcommand)
blankoworld
force-pushed
the
improve-setup-variable-loading
branch
3 times, most recently
from
f6175cc to
2b73e22
Compare
blankoworld
force-pushed
the
improve-setup-variable-loading
branch
2 times, most recently
from
aa518ea to
3d29ec9
Compare
AoNoOokami
approved these changes
Jan 24, 2020
rerowep
requested changes
Jan 24, 2020
blankoworld
force-pushed
the
improve-setup-variable-loading
branch
from
3d29ec9 to
036a573
Compare
* Setup: * Cleans up DeprecationWarning from Python * Cleans up "There are .env of .flaskenv" warning messages * Adds new pipenv command: `setup`. Launch `pipenv run setup` * Deletes all `pipenv run` in scripts/setup file to avoid loading multiple times the same environment * Checks at setup if we are in a virtualenv (via pipenv) Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
improve-setup-variable-loading
branch
from
036a573 to
bb0a2f5
Compare
rerowep
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
pipenv run), we need to reduce it to 1 load.For that I use this tip from Pipenv: https://pipenv.readthedocs.io/en/latest/advanced/#custom-script-shortcuts .
For Python I also use a "ignore DeprecationWarning" state.
How to test?
The setup should only display info messages, things about the setup.
Python DeprecationWarnings should have disappeared.
Code review check list