Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: move to ngx-formly #690

Merged
merged 1 commit into from
Jan 13, 2020
Merged

editor: move to ngx-formly #690

merged 1 commit into from
Jan 13, 2020

Conversation

jma
Copy link
Contributor

@jma jma commented Jan 9, 2020

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Add the new ngx-formly editor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@jma
Copy link
Contributor Author

jma commented Jan 10, 2020

  • editor is slow on firefox: an issue has been created on ngx-formly
  • the "Jump to" list is not always up to date
  • the hidden subfields are not hidden during the editor loading process

@jma
editor: move to ngx-formly
f3dc596 
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma merged commit 2d80af9 into rero:dev Jan 13, 2020
@jma jma deleted the maj-formly branch January 28, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @Garfield-fr @BadrAly