serializer: remove _settings key on aggregations #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-settings-remove
branch
from
c11291b to
ea21ff0
Compare
40 tasks
Garfield-fr
requested review from
jma,
rerowep,
BadrAly,
blankoworld and
sebdeleze
jma
requested changes
Dec 8, 2019
Garfield-fr
force-pushed
the
zub-settings-remove
branch
from
ea21ff0 to
0d5259c
Compare
* Removes RERO_ILS_APP_CONFIG_FACETS on config.py. * Removes _settings key on serializer. Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr
force-pushed
the
zub-settings-remove
branch
from
0d5259c to
01bf449
Compare
jma
approved these changes
Dec 13, 2019
BadrAly
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat [email protected]
Why are you opening this PR?
How to test?
Code review check list