Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1182 - improve perf with MEF #659

Merged
merged 1 commit into from
Dec 10, 2019
Merged

1182 - improve perf with MEF #659

merged 1 commit into from
Dec 10, 2019

Conversation

blankoworld
Copy link
Contributor

Why are you opening this PR?

  • Indexing becomes too slow in rero-ils.

How to test?

To start:

git clone --depth=1 --single-branch --branch 1182-improve-perf-with-mef [email protected]:blankoworld/rero-ils
cd rero-ils
./scripts/bootstrap && docker-compose up -d && ./docker/wait-for-services.sh && ./scripts/setup
./scripts/server

To test:

  • check that UI:
    • contains authors
    • documents have authors
  • check /api with documents/authors (persons)
  • check anything else related to authors/persons!

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@blankoworld blankoworld added the WIP label Dec 6, 2019
@blankoworld
Copy link
Contributor Author

Found bugs

  • document detail view: authors field is empty

@blankoworld blankoworld force-pushed the 1182-improve-perf-with-mef branch from 6362df2 to 0afa13b Compare December 6, 2019 10:48
@AoNoOokami AoNoOokami mentioned this pull request Dec 6, 2019
Closed
40 tasks
@jma
Copy link
Contributor

jma commented Dec 8, 2019

The detailed view for persons and documents need to be adapted, I think.

@blankoworld blankoworld force-pushed the 1182-improve-perf-with-mef branch 6 times, most recently from 4acd9ed to bbc398d Compare December 9, 2019 15:34
@BadrAly BadrAly force-pushed the 1182-improve-perf-with-mef branch from bbc398d to 1ff5e11 Compare December 10, 2019 09:31
@BadrAly BadrAly removed the WIP label Dec 10, 2019
@blankoworld @jma @rerowep
persons: improve performance persons import from MEF
6dcf9c5 
* Adds MEF Person into DB
* Deletes some signals (after_record)
* Uses less requests with DB and ElasticSearch to improve performance
* Transforms get_all_ids() and get_all_pids() in IlsRecord to generator
* Adds new count() method to IlsRecord
* Deletes **RERO\_ILS\_MEF\_HOST** variable
* Renames **mef_persons** module to **persons**

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Olivier DOSSMANN <[email protected]>
Co-Authored-by: Peter Weber <[email protected]>
Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly force-pushed the 1182-improve-perf-with-mef branch from 1ff5e11 to 6dcf9c5 Compare December 10, 2019 10:54
@iGormilhit iGormilhit merged commit c6860dc into rero:dev Dec 10, 2019
@blankoworld blankoworld deleted the 1182-improve-perf-with-mef branch March 30, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerowep rerowep Awaiting requested review from rerowep

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@BadrAly BadrAly Awaiting requested review from BadrAly

@jma jma Awaiting requested review from jma

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blankoworld @jma @iGormilhit @BadrAly