Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: update pr template #638

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Nov 22, 2019

  • BETTER Updates PR template to include translation process.

Co-Authored-by: Alicia Zangger [email protected]

Why are you opening this PR?

To update PR template in order to include translation process.

How to test?

N/A

Remarks

The new template needs to be on master to be used automatically.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

* Updates PR tempalte to include translation process.
* Corrects import sorting.

Co-Authored-by: Alicia Zangger <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-update-pr-template branch from 3e13ff7 to 78da687 Compare November 22, 2019 10:12
@AoNoOokami AoNoOokami self-assigned this Nov 22, 2019
@iGormilhit iGormilhit merged commit 80bd8c5 into rero:dev Nov 25, 2019
@AoNoOokami AoNoOokami deleted the zaa-update-pr-template branch December 6, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants