Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: lazy creation of records #635

Merged
merged 1 commit into from
Nov 22, 2019
Merged

setup: lazy creation of records #635

merged 1 commit into from
Nov 22, 2019

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Nov 20, 2019

  • Adds option for lazy creation of records to the setup.

Co-Authored-by: Peter Weber [email protected]

Why are you opening this PR?

  • The memory consumption is to high for big json files

How to test?

  • run setup with option --lazy

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@rerowep rerowep self-assigned this Nov 21, 2019
@rerowep rerowep changed the title setup: Lazy creation of records setup: lazy creation of records Nov 21, 2019
@rerowep
setup: lazy creation of records
ba5c798 
* Adds option for lazy creation of records to the setup.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep merged commit 2356ada into rero:dev Nov 22, 2019
@rerowep rerowep deleted the lazy-setup branch November 22, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BadrAly BadrAly BadrAly approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerowep @jma @BadrAly