permissions: allow read access to holding and items for all users #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
item-holdings-loan-api
branch
from
98e49e6 to
8ce997f
Compare
BadrAly
requested review from
jma,
rerowep,
AoNoOokami,
benerken,
blankoworld,
Garfield-fr,
lauren-d and
zannkukai
zannkukai
requested changes
Nov 19, 2019
BadrAly
force-pushed
the
item-holdings-loan-api
branch
from
8ce997f to
7219b7f
Compare
zannkukai
approved these changes
Nov 19, 2019
Garfield-fr
approved these changes
Nov 19, 2019
lauren-d
approved these changes
Nov 19, 2019
jma
approved these changes
Nov 19, 2019
* Adds possibilities to access loan API for users of same organisation. * Restricts patron API loan search to his own loans. * Adds organisation to the loan schema. * Permits API access to holdings and items for all type of users. * Changes Loan route from /circulation/loans to /loans. * Sets loan API search sort order to loan transaction_date. Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
item-holdings-loan-api
branch
from
7219b7f to
1def5a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Aly Badr [email protected]
Why are you opening this PR?
Implements task https://tree.taiga.io/project/rero21-reroils/task/1153?kanban-status=1224894
How to test?
scripts/setuppatron:** list your loans via
~/api/loansor for a specific loan~/api/loans/<pid>** list all
holdingsanditemsof the instance via~/api/items/and~/api/holdings/librarianorsystem_librarian:** list all loans of your organisation via
~/api/loansor for a specific loan~/api/loans/<pid>** list all
holdingsanditemsof the instance via~/api/items/and~/api/holdings/Code review check list