fix: loan and items #613
Merged
fix: loan and items #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
force-pushed
the
fix-loan-items
branch
from
414d358 to
f52cd16
Compare
jma
requested changes
Nov 11, 2019
rerowep
force-pushed
the
fix-loan-items
branch
8 times, most recently
from
b3cc1b7 to
17b1ed5
Compare
rerowep
force-pushed
the
fix-loan-items
branch
from
17b1ed5 to
5cd1fb1
Compare
rerowep
force-pushed
the
fix-loan-items
branch
2 times, most recently
from
238357c to
3033322
Compare
iGormilhit
suggested changes
Nov 13, 2019
There was a problem hiding this comment.
Only considering the commit message:
fixtures: fix loans and items
* Corrects small/big loans and items files <explain what kind of correction>.
* Improves error handling and logging for JSON reference resolvers.
* Uses more reliable loading of json files for records creation.
* Improves functions parameters documentation.
3033322 to
c41a4ec
Compare
iGormilhit
approved these changes
Nov 13, 2019
rerowep
force-pushed
the
fix-loan-items
branch
from
c41a4ec to
e2f341a
Compare
zannkukai
approved these changes
Nov 13, 2019
lauren-d
approved these changes
Nov 13, 2019
rerowep
force-pushed
the
fix-loan-items
branch
2 times, most recently
from
12f1b08 to
af927d9
Compare
rerowep
force-pushed
the
fix-loan-items
branch
4 times, most recently
from
602a0f6 to
76d4b93
Compare
BadrAly
approved these changes
Nov 13, 2019
rerowep
force-pushed
the
fix-loan-items
branch
11 times, most recently
from
84cea34 to
cf870cd
Compare
* Corrects small/big loans and items files. There were too few items for the small files. * Improves error handling and logging for JSON reference resolvers. * Uses more reliable loading of json files for records creation. * Improves functions parameters documentation. Co-Authored-by: Peter Weber <[email protected]>
rerowep
force-pushed
the
fix-loan-items
branch
from
cf870cd to
60c699f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Peter Weber [email protected]
Why are you opening this PR?
How to test?
Code review check list