Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fees: add organisation search filter #588

Merged
merged 1 commit into from
Oct 31, 2019
Merged

fees: add organisation search filter #588

merged 1 commit into from
Oct 31, 2019

Conversation

lauren-d
Copy link
Contributor

@lauren-d lauren-d commented Oct 28, 2019 •
edited
Loading

  • Create new signal to enrich data before indexing.
  • Add organisation pid in indexed fields.

Co-Authored-by: Lauren-D [email protected]

Why are you opening this PR?

How to test?

  • ./script/bootstrap
  • ./script/setup
  • login as librarian or system librarian (use account linked to organisation 1)
  • make sure a fine is created at ~/api/fees/1
  • display all fees : ~/api/fees

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@lauren-d lauren-d self-assigned this Oct 28, 2019
@lauren-d lauren-d requested review from a team October 28, 2019 13:37
zannkukai
zannkukai suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Into commit message :

  • title : explain what this commit does, not what was wrong
  • 3 lasts points could be deleted (they come from git template)

Commit title could be "fees: fix fees list-route results" ?

@lauren-d lauren-d force-pushed the lau-#1106-search-api-fees branch from fcaef8d to ece9529 Compare October 28, 2019 13:49
@lauren-d lauren-d changed the title fees: fix api returns 0 records fees: fix search api returns 0 records Oct 28, 2019
@lauren-d lauren-d requested a review from zannkukai October 28, 2019 13:50
@lauren-d lauren-d force-pushed the lau-#1106-search-api-fees branch from ece9529 to 5da749c Compare October 29, 2019 08:41
@lauren-d lauren-d requested a review from zannkukai October 29, 2019 08:42
jma
jma requested changes Oct 29, 2019
View reviewed changes
@lauren-d lauren-d force-pushed the lau-#1106-search-api-fees branch from 5da749c to 84a3592 Compare October 29, 2019 15:23
@lauren-d lauren-d requested review from jma and zannkukai October 29, 2019 15:27
@iGormilhit iGormilhit self-requested a review October 30, 2019 07:05
iGormilhit
iGormilhit suggested changes Oct 30, 2019
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message title should begin with a verb and explain why this commit is useful.

@lauren-d lauren-d force-pushed the lau-#1106-search-api-fees branch from 84a3592 to 70f9f58 Compare October 30, 2019 08:28
@lauren-d lauren-d changed the title fees: fix search api returns 0 records fees: add organisation search filter Oct 30, 2019
@lauren-d lauren-d requested a review from iGormilhit October 30, 2019 08:31
@lauren-d
fees: add organisation search filter
3d33731 
* Create new signal to enrich data before indexing.
* Add organisation pid in indexed fields.
* Closes rero#560 (search api return 0 records).

Co-Authored-by: Lauren-D <[email protected]>
@lauren-d lauren-d force-pushed the lau-#1106-search-api-fees branch from 70f9f58 to 3d33731 Compare October 30, 2019 09:10
jma
jma approved these changes Oct 31, 2019
View reviewed changes
tests/api/test_fees.py Outdated
# Martigny
login_user_via_session(client, librarian_martigny_no_email.user)
list_url = url_for('invenio_records_rest.fee_list')
print(list_url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be removed

@jma jma merged commit 0132598 into rero:dev Oct 31, 2019
@lauren-d lauren-d deleted the lau-#1106-search-api-fees branch January 28, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jma jma jma approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@lauren-d lauren-d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lauren-d @jma @iGormilhit @zannkukai