Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add new info on github issue template #581

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

blankoworld
Copy link
Contributor

@blankoworld blankoworld commented Oct 24, 2019

Co-Authored-by: Olivier DOSSMANN [email protected]

Why are you opening this PR?

Sometimes to resolve issues on RERO-ILS we need to know from which version the user come from.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message title, use documentation instead of github for the component. And maybe something like documentation: ask for which version in issue template, if it's not too long.

@@ -20,6 +20,9 @@ Steps to reproduce the behavior:
**Expected behavior**
A clear and concise description of what you expected to happen.

**Software version**
From which version do you come from?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain what kind of information is useful (which server, ils.test or ilsdev, which tags or which commit hash) and where one can get it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed. Ask me if anything else could be improved.

@blankoworld blankoworld force-pushed the doo-github-issue-template branch from 4a25f11 to dcfd5d1 Compare October 28, 2019 09:39
@blankoworld blankoworld force-pushed the doo-github-issue-template branch from dcfd5d1 to df906d5 Compare October 28, 2019 09:40
@blankoworld blankoworld merged commit b28f2bc into rero:dev Oct 28, 2019
@blankoworld blankoworld deleted the doo-github-issue-template branch March 30, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants