items: fix online locations status

[zannkukai]

• Fix data/location.json file : According to PO, removing location named 'Online' with no flag is_online=True
• Closes "online" item type in fixture #573

Co-Authored-by: Renaud Michotte [email protected]

How to test?

• run scripts/setup
• run curl -XPOST -H 'Content-Type: application/json' "http://localhost:9200/locations/_search?pretty" -d '{"query": {"term": { "is_online": true } } } }' to get online location pids. Result must be [12,18,4]
• run curl -XPOST -H 'Content-Type: application/json' "http://localhost:9200/items/_search?pretty" -d '{"query": {"terms": { "location.pid": [12, 18, 4] } } }' to get number if items in these locations. The number should be "0"

Code review check list

• Commit message template compliance.
• Commit message without typos.
• File names.
• Functions names.
• Functions docstrings.
• Unnecessary commited files?

[iGormilhit]

For the commit message:

• title: explain what this commit does, not what was wrong
• message: use sentence, with verbs, and there you can explain why this is necessary
• do not forget Closes rero/rero-ils#<issue-pid>

Thanks !

[AoNoOokami]

Curl requests didn't work on localhost:9200, so I tested with Kibana on localhost:5601. The results are the expected ones.