ui: add a new URL to change the language #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a new HTTP endpoint with a JSON POST or PUT method to change the session language: this will be usefull to change the language from a pure js application. Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
requested review from
Garfield-fr,
AoNoOokami,
BadrAly,
blankoworld,
iGormilhit,
lauren-d and
sebdeleze
lauren-d
approved these changes
Oct 18, 2019
AoNoOokami
approved these changes
Oct 18, 2019
iGormilhit
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session language: this will be usefull to change the language from a
pure js application.
Co-Authored-by: Johnny Mariéthoz [email protected]
Why are you opening this PR?
How to test?
curl -d '{"lang":"fr"}' -H "Content-Type: application/json" -X POST http://localhost:5000/language, the language should be changed.Code review check list