ils: translates v0.5.0 strings #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* NEW Translates strings for fees resources and holdings for harvested ebooks. * BETTER Harmonizes strings between api, schemas and form options. * FIX Fixes wrong end of line inside strings to be translated (javascript), in the circulation policies editor. * FIX Fixes typo in a string on the frontpage. Co-Authored-by: Igor Milhit <[email protected]>
jma
approved these changes
Oct 18, 2019
|
@jma No, it's not anymore required. I kept the habit, though, as it's not forbidden. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ebooks.
(javascript), in the circulation policies editor.
Co-Authored-by: Igor Milhit [email protected]
Why are you opening this PR?
v0.5.0).How to test?
./run-tests.shCode review check list