US965: Holdings/items for ebooks #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
changed the title
rerodak
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
Problems observed:
- Ebooks are not displayed/indexed in the local views
- Ebooks are displayed in the local views if they have a physical items
- In the global view, the organisation facet has wrong count for ebooks
- Availability info should not be displayed for ebooks. It is displayed in the document detailed view, when the holding is not expanded.
- Number of items should never be displayed for ebooks. It is displayed in the document detailed view, on the holding.
* Adds online locations. * Adds online item types. * Adds circulation policies for ebooks. Co-Authored-by: Alicia Zangger <[email protected]>
* Adds online type to item types resource. * Adds is_online to location resource. * Adds online_harvested_source to the organisation resource. * Adds extended validation for the resource location field is_online. * Adds extended validation for the resource item_type field type. * Adds an option to setup script to continue process after holding_items generation. * Fixes some variables snake cases. * Fixes typos. Co-Authored-by: Alicia Zangger <[email protected]> Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Alicia Zangger <[email protected]>
* Adds custom widgets * Adds a new column "type" on item_type * Adds a new column "is_online" on location Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Alicia Zangger <[email protected]>
Co-Authored-by: Aly Badr <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
pronguen
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test?
./script/bootstrap./script/setup(with harvested ebook)online(unicity)is_online(unicity)Co-Authored-by: Aly Badr [email protected]
Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Alicia Zangger [email protected]