#1021 - refactoring: delete unused imports

[blankoworld]

More and more imports are useless in the project.

To avoid this problem, 2 things are needed:

• delete current imports
• check imports regularly

To delete current imports it uses a program: autoflakes

autoflake --remove-all-unused-imports -i -r --exclude ui \
--ignore-init-module-imports .

Also checks that no more useless imports remains. It also uses
autoflakes during run-tests.sh script.

[BadrAly]

I do not know if we are allowed to have execution commands on the commit message. I will leave this to @iGormilhit to confirm.

[rerowep]

Are the celery worker tasks: indexer, accounts, ebooks-harvester, notification-creation still functional and executed in a celery worker?

[blankoworld]

Are the celery worker tasks: indexer, accounts, ebooks-harvester, notification-creation still functional and executed in a celery worker?

That's a good point. Have I any way to check this quickly @rerowep ?

[rerowep]

Are the celery worker tasks: indexer, accounts, ebooks-harvester, notification-creation still functional and executed in a celery worker?

That's a good point. Have I any way to check this quickly @rerowep ?

• bootstrap
• start server with celery workers pipenv run celery worker -A invenio_app.celery --autoscale=8,1 --beat -l WARNING --without-heartbeat & pid_celery=$!
• setup
• control if you see errors in the server log after some time

[iGormilhit]

About the commit message:

* Uses autoflake to remove current useless python imports. The command is `autoflake --remove-all-unused-imports -i -r --exclude ui --ignore-init-module-imports`.
* Uses autoflake in `run-tests.sh` script, to check for useless python imports regularly.

I do like informative commit message, but let's try to not be too verbose.

[rerowep]

Are the celery worker tasks: indexer, accounts, ebooks-harvester, notification-creation still functional and executed in a celery worker?