Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data: new data files for MEF #535

Merged
merged 1 commit into from
Sep 30, 2019
Merged

data: new data files for MEF #535

merged 1 commit into from
Sep 30, 2019

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Sep 30, 2019 •
edited
Loading

  • Corrects dojson and implements RERO_ILS_MEF_HOST enviroment variable.
  • Creats new documents, holdings and items files

To test, following environment variables have to be changed:

RERO_ILS_MEF_HOST='mefdev.test.rero.ch'
RERO_ILS_MEF_URL="https://mefdev.test.rero.ch/api/mef/"

iGormilhit
iGormilhit suggested changes Sep 30, 2019
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, everything's working fine, but, commit message:

data: update fixtures files with updated MEF data

* Corrects dojson and implements RERO_ILS_MEF_HOST environment variable.
* Creates new documents, holdings and items files.

@rerowep rerowep force-pushed the wep-#1053-new-documents-files branch from a78a4b9 to 54a2666 Compare September 30, 2019 10:29
@rerowep rerowep force-pushed the wep-#1053-new-documents-files branch from 54a2666 to 4805a51 Compare September 30, 2019 10:31
@rerowep
data: update fixtures files with updated MEF data
208b73f 
* Corrects dojson and implements RERO_ILS_MEF_HOST environment variable.
* Creates new documents, holdings and items files.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep force-pushed the wep-#1053-new-documents-files branch from 4805a51 to 208b73f Compare September 30, 2019 11:22
@iGormilhit iGormilhit merged commit f97b9b4 into rero:dev Sep 30, 2019
@rerowep rerowep deleted the wep-#1053-new-documents-files branch October 1, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@BadrAly BadrAly BadrAly approved these changes

@jma jma Awaiting requested review from jma

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rerowep @iGormilhit @BadrAly