editor: fix submit button with async validator #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jma
force-pushed
the
maj-fix-editor-asyncvalidator
branch
from
ebb498a to
d0aed89
Compare
jma
requested review from
AoNoOokami,
Garfield-fr,
iGormilhit and
sebdeleze
Garfield-fr
reviewed
Sep 26, 2019
| @@ -217,6 +221,7 @@ export class EditorComponent implements OnInit { | |||
| } | |||
|
|
|||
| validationErrors(errors) { | |||
| this.formValidationErrors = errors; | |||
| // this.formValidationErrors = errors; | |||
AoNoOokami
approved these changes
Sep 26, 2019
jma
force-pushed
the
maj-fix-editor-asyncvalidator
branch
from
d0aed89 to
6bcc4eb
Compare
Garfield-fr
approved these changes
Sep 26, 2019
jma
force-pushed
the
maj-fix-editor-asyncvalidator
branch
from
6bcc4eb to
e698b74
Compare
sebdeleze
approved these changes
Sep 26, 2019
jma
force-pushed
the
maj-fix-editor-asyncvalidator
branch
from
e698b74 to
1ee45a7
Compare
* Disables submit button for invalid async validator: i.e. for item barcode uniqueness validation. * Removes useless debug traces. * Uses core unique validator for remote input component. Co-Authored-by: Johnny Mariéthoz <[email protected]> Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Alicia Zangger <[email protected]>
jma
force-pushed
the
maj-fix-editor-asyncvalidator
branch
from
1ee45a7 to
63e37d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz [email protected]
Co-Authored-by: Bertrand Zuchuat [email protected]
Co-Authored-by: Alicia Zangger [email protected]
To Test