US931 data model publication statement #526

rerowep · 2019-09-25T09:33:29Z

data model: implement publication statement for ebooks
* Implements the publication statement transformation for ebooks.
* Uniforms the function names to snake_case (PEP8).
* Refactors Marc21 punctation handling.
* Fixes copyright date transformation.

ui: correct document brief views
* Adds publication statement to admin and public brief document view.

ui: adapt editor according to publication statement data model
* Removes publication date field

ES: adapt ES mapping for publication statement
* Adapts the ES mapping for publication statement.

data model: implement publication statement transformation for BNF
* Implements the publication statement transformation for BNF.
* Adds base class for marc dojson transformation.
* Adds colored message functions to `setup` and `bootstrup` scripts

UI:display the publication statement
* Displays the publication statement on detailed view.

template: correct email templates
* Removes item at desk templates for patron and according methods and tests.

data model: implement publication statement transformation
* Implements the publication statement transformation.
* Adds the dojson overdo class with blob.
* Adds functions to manipulate the Marc21 blob.
* Adapts the fixtures.
* Adds parameters to the setup for generating items and holdings data.

data: correct language in big document file
* Corrects notice 704 tag 008 esp->sp.

* Implements the publication statement transformation. * Adds the dojson overdo class with blob. * Adds functions to manipulate the Marc21 blob. * Adapts the fixtures. * Adds parameters to the setup for generating items and holdings data. Co-Authored-by: Gianni Pante <[email protected]> Co-Authored-by: Peter Weber <[email protected]>

* Removes item at desk templates for patron and according methods and tests. Co-Authored-by: Alicia Zangger <[email protected]>

* Displays the publication statement on detailed view. Co-Authored-by: [Alicia Zangger] <[email protected]>

* Implements the publication statement transformation for BNF. * Adds base class for marc dojson transformation. * Adds colored message functions to `setup` and `bootstrup` scripts Co-Authored-by: Peter Weber <[email protected]>

* Adapts the ES mapping for publication statement. Co-Authored-by: Peter Weber <[email protected]>

* Removes publication date field Co-Authored-by: Alicia Zangger <[email protected]>

* Adds publication statement to admin and public brief document view. Co-Authored-by: Peter Weber <[email protected]>

* Implements the publication statement transformation for ebooks. * Uniforms the function names to snake_case (PEP8). * Refactors Marc21 punctation handling. * Fixes copyright date transformation. Co-Authored-by: Gianni Pante <[email protected]> Co-Authored-by: Peter Weber <[email protected]>

* Corrects notice 704 tag 008 esp->sp. Co-Authored-by: Peter Weber <[email protected]>

pronguen

Problem detected:

The import from BNF does not work. Try to import 9782286135041, it is impossible to save the form since the "save" button is not displayed (it seems that a part of the form is hidden).

No other problem found!

* Deletes `Publishers` and `Dates of publication` from documents json form. Co-Authored-by: Peter Weber <[email protected]>

Co-Authored-by: Peter Weber <[email protected]>

NicolasLabat · 2019-09-26T08:12:15Z

In the detailed view the heading for the publication statement is "bf:Publication:" --> to correct without "bf:". Is the heading "Publication" correct ?

iGormilhit

I know that's not always concerning this very PR…

rero_ils/modules/documents/jsonschemas/documents/document-v0.0.1_src.json

NicolasLabat · 2019-09-26T08:43:34Z

Same for "bf:Manufacture"

pronguen · 2019-09-26T08:49:10Z

In the detailed view the heading for the publication statement is "bf:Publication:" --> to correct without "bf:". Is the heading "Publication" correct ?

@NicolasLabat Is addressed by the translations

NicolasLabat · 2019-09-26T08:55:09Z

In case of a 264 like $a : $b ; $a : $b the ; is replaced by : but has be to kept.
Ex :
264 _1 $a [Lieu de publication non identifié] : $b SZ ; $a [Paris] : $b Arte France [prod.], $c [2001]
is now displayed :
[Lieu de publication non identifié] : SZ : [Paris] : Arte France [prod.], [2001]
Must be :
[Lieu de publication non identifié] : SZ ; [Paris] : Arte France [prod.], [2001]

NicolasLabat

Comments in the PR

* Corrects discriptions in document json schema * Implements translations from transifex * Fixs punctuation between blocks (;) and places (:) Co-Authored-by: Peter Weber <[email protected]>

NicolasLabat

Is this correct or should endDate be "1970" ?

"provisionActivity": [
{
"date": "1955-1970",
"endDate": "1969",
"startDate": "1955",

rerowep requested review from pronguen and NicolasLabat September 25, 2019 09:33

rerowep added the dev deployment request label Sep 25, 2019

rerowep changed the title ~~Us931 data model publication statement~~ US931 data model publication statement Sep 25, 2019

reropag and others added 8 commits September 25, 2019 11:43

template: correct email templates

71e095c

* Removes item at desk templates for patron and according methods and tests. Co-Authored-by: Alicia Zangger <[email protected]>

UI:display the publication statement

efd2b29

* Displays the publication statement on detailed view. Co-Authored-by: [Alicia Zangger] <[email protected]>

ES: adapt ES mapping for publication statement

fe6c78b

* Adapts the ES mapping for publication statement. Co-Authored-by: Peter Weber <[email protected]>

ui: adapt editor according to publication statement data model

876411c

* Removes publication date field Co-Authored-by: Alicia Zangger <[email protected]>

ui: correct document brief views

330b27c

* Adds publication statement to admin and public brief document view. Co-Authored-by: Peter Weber <[email protected]>

rerowep force-pushed the US931-data-model-publication-statement branch from a1747db to 824cb3a Compare September 25, 2019 09:43

data: correct language in big document file

e0fa1c3

* Corrects notice 704 tag 008 esp->sp. Co-Authored-by: Peter Weber <[email protected]>

rerowep added deployed on dev and removed dev deployment request labels Sep 25, 2019

pronguen reviewed Sep 25, 2019

View reviewed changes

editor: correct documents json form

7fd4618

* Deletes `Publishers` and `Dates of publication` from documents json form. Co-Authored-by: Peter Weber <[email protected]>

rerowep force-pushed the US931-data-model-publication-statement branch from ad24b30 to 7fd4618 Compare September 25, 2019 21:15

translations: translates missing strings

fc1999a

Co-Authored-by: Peter Weber <[email protected]>

rerowep requested a review from iGormilhit September 26, 2019 08:10

iGormilhit suggested changes Sep 26, 2019

View reviewed changes

NicolasLabat suggested changes Sep 26, 2019

View reviewed changes

rerowep force-pushed the US931-data-model-publication-statement branch 2 times, most recently from fddec9a to cfca620 Compare September 26, 2019 12:28

json: correct discriptions schema and translations

d7a0128

* Corrects discriptions in document json schema * Implements translations from transifex * Fixs punctuation between blocks (;) and places (:) Co-Authored-by: Peter Weber <[email protected]>

rerowep force-pushed the US931-data-model-publication-statement branch from cfca620 to d7a0128 Compare September 26, 2019 13:33

rerowep requested review from iGormilhit, NicolasLabat and pronguen September 26, 2019 13:46

iGormilhit approved these changes Sep 26, 2019

View reviewed changes

NicolasLabat reviewed Sep 26, 2019

View reviewed changes

NicolasLabat self-requested a review September 26, 2019 14:13

NicolasLabat approved these changes Sep 26, 2019

View reviewed changes

pronguen approved these changes Sep 26, 2019

View reviewed changes

rerowep merged commit 62c8ee5 into dev Sep 26, 2019

rerowep deleted the US931-data-model-publication-statement branch October 1, 2019 06:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

US931 data model publication statement #526

US931 data model publication statement #526

rerowep commented Sep 25, 2019 •

edited

Loading

pronguen left a comment

NicolasLabat commented Sep 26, 2019 •

edited

Loading

iGormilhit left a comment

NicolasLabat commented Sep 26, 2019

pronguen commented Sep 26, 2019 •

edited

Loading

NicolasLabat commented Sep 26, 2019

NicolasLabat left a comment

NicolasLabat left a comment

US931 data model publication statement #526

US931 data model publication statement #526

Conversation

rerowep commented Sep 25, 2019 • edited Loading

pronguen left a comment

Choose a reason for hiding this comment

NicolasLabat commented Sep 26, 2019 • edited Loading

iGormilhit left a comment

Choose a reason for hiding this comment

NicolasLabat commented Sep 26, 2019

pronguen commented Sep 26, 2019 • edited Loading

NicolasLabat commented Sep 26, 2019

NicolasLabat left a comment

Choose a reason for hiding this comment

NicolasLabat left a comment

Choose a reason for hiding this comment

rerowep commented Sep 25, 2019 •

edited

Loading

NicolasLabat commented Sep 26, 2019 •

edited

Loading

pronguen commented Sep 26, 2019 •

edited

Loading