circulation : fix checkin of item that should go in transit #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
requested review from
BadrAly,
rerowep,
AoNoOokami,
blankoworld and
Garfield-fr
benerken
force-pushed
the
bee-#1026-checkin_transit
branch
2 times, most recently
from
734f56e to
34f24df
Compare
BadrAly
suggested changes
Sep 23, 2019
rero_ils/modules/items/api.py
Outdated
| @@ -711,8 +711,7 @@ def item_location_retriever(cls, item_pid, **kwargs): | |||
| # to deal with multiple pickup locations for a library | |||
| item = cls.get_record_by_pid(item_pid) | |||
| if item: | |||
| library = item.get_library_of_last_location() | |||
| return library.get_pickup_location_pid() | |||
| return item.get_owning_pickup_location_pid() | |||
There was a problem hiding this comment.
I recall that the PO asked to not rely on the the pickup location of the owning library. Instead he asked to find where the item is actually now by checking the library of the last transaction loan. This is a use case not documented in the Circulation state chart https://github.com/rero/rero-ils/blob/master/doc/circulation_statechart/circulation_loan_statechart.pdf.
The outcome, keep the two lines:
library = item.get_library_of_last_location()
return library.get_pickup_location_pid()
lauren-d
force-pushed
the
bee-#1026-checkin_transit
branch
from
34f24df to
f9ce4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Benoit Erken [email protected]