holdings: display holdings records #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
requested review from
jma,
Garfield-fr,
reropag,
AoNoOokami,
blankoworld,
iGormilhit,
rerowep and
NicolasLabat
NicolasLabat
approved these changes
Sep 13, 2019
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
from
8619566 to
ce9d2cd
Compare
NicolasLabat
approved these changes
Sep 16, 2019
pronguen
suggested changes
Sep 16, 2019
There was a problem hiding this comment.
- for available items, we should display "green dot + on shelf" ("available" is generic, for holding and document availability)
- For holding location, we should display "library code: location name"
- the loan status (for example "on_loan", "on_shelf") should not be displayed. The availability information is sufficient.
- Some documents have empty holdings (doc 277, doc 277, doc 284). It should be impossible.
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
2 times, most recently
from
628163b to
02fe633
Compare
it depends on the view. For example: (doc 277 highlands (one item available in highlands, one item unavailable at Aoste but we can not display the item of Aoste). (doc 277 global (two items are displayed). |
Of course. We should display in the views only the corresponding holdings! |
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
from
02fe633 to
8509909
Compare
Garfield-fr
requested changes
Sep 17, 2019
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
jma
requested changes
Sep 17, 2019
rero_ils/modules/documents/templates/rero_ils/detailed_view_documents.html
Outdated
Show resolved
Hide resolved
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
2 times, most recently
from
3e7ad2d to
c076ed2
Compare
jma
approved these changes
Sep 17, 2019
jma
reviewed
Sep 17, 2019
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
2 times, most recently
from
acd8a1f to
c043891
Compare
Garfield-fr
approved these changes
Sep 17, 2019
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
2 times, most recently
from
2b5d286 to
e5fa667
Compare
pronguen
suggested changes
Sep 17, 2019
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
2 times, most recently
from
895a873 to
9c71d2e
Compare
iGormilhit
approved these changes
Sep 18, 2019
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
from
9c71d2e to
c63d8c2
Compare
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
from
c63d8c2 to
0605535
Compare
* Adds holdings records display to the document detailed view. Co-Authored-by: Sebastien Deleze <[email protected]> Co-Authored-by: Aly Badr <[email protected]> Co-Authored-by: Bertrand Zuchuat <[email protected]>
BadrAly
force-pushed
the
baa-#1025-display-holdings
branch
from
0605535 to
79c32f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Sebastien Deleze [email protected]
Co-Authored-by: Aly Badr [email protected]
Co-Authored-by: bertrand Zuchuat [email protected]
To test: