Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publication statement view #494

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Publication statement view #494

merged 2 commits into from
Sep 18, 2019

Conversation

AoNoOokami
Copy link
Contributor

Test with ISBN 9785852550378

@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch 3 times, most recently from 444209e to c9d6b1c Compare September 11, 2019 12:41
BadrAly
BadrAly suggested changes Sep 11, 2019
View reviewed changes
Copy link

@BadrAly BadrAly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rebase to US931 or rebase the US931 to dev... to have only 2 commits instead of 3.

@AoNoOokami AoNoOokami added the WIP label Sep 12, 2019
@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch 3 times, most recently from 79a89d7 to f7bed49 Compare September 17, 2019 15:14
@iGormilhit iGormilhit self-requested a review September 18, 2019 05:20
iGormilhit
iGormilhit reviewed Sep 18, 2019
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message, a proposition (minor changes):

 ui: display the publication statement

* Displays the publication statement on detailed view.

@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch 2 times, most recently from 0c87d2b to 3571040 Compare September 18, 2019 08:02
@AoNoOokami AoNoOokami removed the WIP label Sep 18, 2019
@AoNoOokami AoNoOokami added WIP and removed WIP labels Sep 18, 2019
@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch 2 times, most recently from 8a60c21 to d13c00e Compare September 18, 2019 09:54
@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch from d13c00e to 488f9ef Compare September 18, 2019 12:01
Garfield-fr
Garfield-fr reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@Garfield-fr Garfield-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit title: make space after ":"

@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch from 488f9ef to 8a4f86f Compare September 18, 2019 13:51
@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch from 8a4f86f to 371e749 Compare September 18, 2019 14:26
@reropag @rerowep
data model: implement publication statement transformation
bf928a1 
* Implements the publication statement transformation.
* Adds the dojson overdo class with blob.
* Adds functions to manipulate the Marc21 blob.
* Adapts the fixtures.
* Adds parameters to the setup for generating items and holdings data.

Co-Authored-by: Gianni Pante <[email protected]>
Co-Authored-by: Peter Weber <[email protected]>
ui: display the publication statement
7a7a0d4 
* Displays the publication statement on detailed view.

Co-Authored-by: [Alicia Zangger] <[email protected]>
@AoNoOokami AoNoOokami force-pushed the zaa-#1014-publication-stat-view branch from 07faa78 to 7a7a0d4 Compare September 18, 2019 15:14
@AoNoOokami AoNoOokami merged commit 450cc06 into rero:US931-data-model-publication-statement Sep 18, 2019
@AoNoOokami AoNoOokami deleted the zaa-#1014-publication-stat-view branch September 18, 2019 15:38
@AoNoOokami AoNoOokami restored the zaa-#1014-publication-stat-view branch September 18, 2019 17:38
@AoNoOokami AoNoOokami deleted the zaa-#1014-publication-stat-view branch September 23, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@rerowep rerowep rerowep approved these changes

@jma jma Awaiting requested review from jma

@blankoworld blankoworld Awaiting requested review from blankoworld

@reropag reropag Awaiting requested review from reropag

@iGormilhit iGormilhit Awaiting requested review from iGormilhit

@BadrAly BadrAly Awaiting requested review from BadrAly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AoNoOokami @Garfield-fr @iGormilhit @BadrAly @rerowep @reropag