US838: display record availability #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
force-pushed
the
US838
branch
3 times, most recently
from
f7920bb to
d40a26b
Compare
pronguen
reviewed
Sep 12, 2019
There was a problem hiding this comment.
Some cases are difficult to test because of issue #462, for example "in transit" cases.
Important to solve
- If an item changes its availability and if this impact the document availability, the document availability in the document brief view does not change (at least not right away).
Less important, but to solve
- when there is only one request, the item availability shows "1 requests" with s
- when the item is not on loan and, not in transit and holds a request, the item availability shows "(1 requests)". The parenthesis should not be displayed in this case.
Optional / for later
- replace item status by item availability on the item detailed page
BadrAly
force-pushed
the
US838
branch
3 times, most recently
from
47a6c0f to
c2ff126
Compare
pronguen
approved these changes
Sep 12, 2019
* Adapts existing item availability. * Provides availability reasons when item is not available. Co-Authored-by: Laurent Dubois <[email protected]> Co-Authored-by: Aly Badr <[email protected]>
* Adds holding availability. * Provides availability loan conditions for holdings records. Co-Authored-by: Laurent Dubois <[email protected]> Co-Authored-by: Aly Badr <[email protected]>
* add holding availability. Co-Authored-by: Laurent Dubois <[email protected]>
* Displays document and item availabilites in document detailed view. * Displays holding availability in holding detailed view. * Closes #445 Co-Authored-by: Aly Badr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Laurent Dubois [email protected]
Co-Authored-by: Aly Badr [email protected]
To test:
(This is a temporary display of availabilities until US963 is implemented)
http://localhost:5000/aoste/documents/xxx
http://localhost:5000/aoste/holdings/xx