installation: fix bootstrap script to use npm 6 instead of local one #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGormilhit
suggested changes
Sep 5, 2019
rerowep
approved these changes
Sep 5, 2019
blankoworld
force-pushed
the
fix-bootstrap-script
branch
from
de4c511 to
1fe4662
Compare
* use npm in pipenv instead of local one Co-Authored-by: Olivier DOSSMANN <[email protected]>
blankoworld
force-pushed
the
fix-bootstrap-script
branch
from
1fe4662 to
6fe5d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I start using ./scripts/bootstrap file on my computer. With npm 5.6.0.
The script failed and ask it doesn't know
npm cicommand.As I expected the script to use the virtualenv npm version (6.11.3), I fixed ./scripts/bootstrap to use npm in the pipenv virtual environment.
Co-Authored-by: Olivier DOSSMANN [email protected]