circulation: upgrade to invenio-circulation v1.0.0a16 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
requested changes
Aug 9, 2019
reropag
force-pushed
the
pag-#941-upgrade-invenio-circulation-v1.0.0a15
branch
from
85d8a51 to
f7515ae
Compare
BadrAly
suggested changes
Aug 12, 2019
reropag
force-pushed
the
pag-#941-upgrade-invenio-circulation-v1.0.0a15
branch
2 times, most recently
from
570b757 to
19c1b70
Compare
Done |
reropag
force-pushed
the
pag-#941-upgrade-invenio-circulation-v1.0.0a15
branch
from
19c1b70 to
d0a733e
Compare
BadrAly
approved these changes
Aug 13, 2019
jma
approved these changes
Aug 13, 2019
* Changes loan_pid to pid. * Improves checkout duration type from int to timedelta. Co-Authored-by: Gianni Pante <[email protected]>
reropag
force-pushed
the
pag-#941-upgrade-invenio-circulation-v1.0.0a15
branch
from
d0a733e to
697a77f
Compare
pronguen
reviewed
Aug 14, 2019
There was a problem hiding this comment.
Maybe a new problem:
- checkout for patron A on item requested by patron A but not validated
- checkout is allowed (as expected) and works properly
- the request should disappear from the list of the requests to validate, but it is not the case. The request never disappears.
Problem from before:
- checkin on item on loan, owned by another library > it should become "in transit", but it becomes directly "on shelf". For this reason, some use cases cannot be tested (there are no item at all "in transit" currently).
Garfield-fr
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Gianni Pante [email protected]
to test:
bootstrap, setup
test circulation transactions