circulation: improve circulation dates #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadrAly
changed the title
BadrAly
force-pushed
the
baa-policy-from-logged-user-library
branch
2 times, most recently
from
81a9a1e to
7c4fd29
Compare
BadrAly
changed the title
iGormilhit
approved these changes
Jul 4, 2019
pronguen
suggested changes
Jul 4, 2019
There was a problem hiding this comment.
Problem description:
Adding a day exception for 3rd August without filling the hours (see pic below) AND THEN doing a checkout with theoretical due date 3rd August. System should look for next open day, but it gives 3rd August as due date.
However, a period exception (more than one day) works perfectly.
BadrAly
force-pushed
the
baa-policy-from-logged-user-library
branch
from
7c4fd29 to
fc45d2a
Compare
* Fixes issue when a library exception opening day is considered as closed. * Fixes closes rero#378. * Fixes closes rero#263. * Improves the calculation of the due date of a circulation transaction. Now it is based on the transaction library instead of item owning library. Co-Authored-by: Aly Badr <[email protected]>
BadrAly
force-pushed
the
baa-policy-from-logged-user-library
branch
from
fc45d2a to
e89cc9a
Compare
pronguen
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Aly Badr [email protected]