fix(circulation policies): improve data consistency #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PascalRepond
commented
Jul 26, 2024
PascalRepond
commented
- Reorders jsonschema to be more coherent.
- Adds hide and required expressions for the cipo editor so that checkouts and renewals settings are consistent with one another.
- Adds an extended validation to prevent circulation policies with renewals enabled but no renewal_duration, which would lead to an error when trying to renew.
github-actions
bot
added
f: circulation
* Reorders jsonschema to be more coherent. * Adds hide and required expressions for the cipo editor so that checkouts and renewals settings are consistent with one another. * Adds an extended validation to prevent circulation policies with renewals enabled but no renewal_duration, which would lead to an error when trying to renew. Co-Authored-by: Pascal Repond <[email protected]>
rerowep
approved these changes
Jul 26, 2024
jma
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.