document: Publisher format #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My proposition for ignoring empty publishers and so avoid {} in publishers array. I'm not sure if that works because I cannot setup the project locally.. |
BadrAly
reviewed
Jul 2, 2019
| return publishers | ||
|
|
||
| if publisher: | ||
| publishers.append(publisher) |
There was a problem hiding this comment.
I think your are missing return something?
iGormilhit
suggested changes
Jul 2, 2019
iGormilhit
approved these changes
Jul 2, 2019
- FIX Ignores empty publisher in dojson conversion. - FIX Fixes #367 Co-Authored-by: Sébastien Délèze <[email protected]>
BadrAly
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX Ignore empty publisher in dojson conversion.
Signed-off-by: Sébastien Délèze [email protected]