Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facets: expand facet items by link #364

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Jun 28, 2019

How to test:

  • script/bootstrap
  • Search in documents
  • Check link on facets (see only if the facet results > 10)

Co-Authored-by: Bertrand Zuchuat [email protected]

@Garfield-fr Garfield-fr force-pushed the zub-issue87-facets branch 3 times, most recently from 5cdd888 to b338685 Compare July 8, 2019 12:07
rero_ils/config.py Outdated Show resolved Hide resolved
ui/src/app/records/search/search.component.html Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr force-pushed the zub-issue87-facets branch 2 times, most recently from 43d3d31 to ba86e06 Compare July 9, 2019 15:39
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

Commit message title: facets: expand facet items by link (proposition)

rero_ils/utils.py Outdated Show resolved Hide resolved
@Garfield-fr Garfield-fr changed the title Facets: link to expand results facets: expand facet items by link Jul 11, 2019
@Garfield-fr Garfield-fr requested a review from jma July 11, 2019 06:34
Copy link
Contributor

@pronguen pronguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facet status is populated with subjects

* Adds a link to see more or less results on the facet.
* Closes rero#87

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma merged commit b85e5b5 into rero:dev Jul 11, 2019
@Garfield-fr Garfield-fr deleted the zub-issue87-facets branch July 16, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants