-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
facets: expand facet items by link #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-issue87-facets
branch
3 times, most recently
from
July 8, 2019 12:07
5cdd888
to
b338685
Compare
jma
requested changes
Jul 8, 2019
Garfield-fr
force-pushed
the
zub-issue87-facets
branch
2 times, most recently
from
July 9, 2019 15:39
43d3d31
to
ba86e06
Compare
iGormilhit
suggested changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice!
Commit message title: facets: expand facet items by link
(proposition)
Garfield-fr
force-pushed
the
zub-issue87-facets
branch
from
July 11, 2019 06:00
ba86e06
to
bb9afbd
Compare
Garfield-fr
changed the title
Facets: link to expand results
facets: expand facet items by link
Jul 11, 2019
iGormilhit
approved these changes
Jul 11, 2019
jma
approved these changes
Jul 11, 2019
pronguen
suggested changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facet status is populated with subjects
* Adds a link to see more or less results on the facet. * Closes rero#87 Co-Authored-by: Bertrand Zuchuat <[email protected]> Co-Authored-by: Johnny Mariéthoz <[email protected]>
Garfield-fr
force-pushed
the
zub-issue87-facets
branch
from
July 11, 2019 11:31
bb9afbd
to
7e86c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
script/bootstrap
Co-Authored-by: Bertrand Zuchuat [email protected]