Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user: create token cli #3575

Merged
merged 1 commit into from
Jan 24, 2024
Merged

user: create token cli #3575

merged 1 commit into from
Jan 24, 2024

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Jan 9, 2024

  • Deletes obsolete code for user token creation.
  • Replaces all string format functions with f strings.

@rerowep rerowep self-assigned this Jan 9, 2024
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. f: user management labels Jan 9, 2024
@rerowep rerowep force-pushed the wep-user-token branch 2 times, most recently from 5f17947 to 6a7d6be Compare January 9, 2024 19:47
@rerowep rerowep marked this pull request as ready for review January 10, 2024 09:04
Garfield-fr
Garfield-fr approved these changes Jan 10, 2024
View reviewed changes
rero_ils/modules/imports/serializers/serializers.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/utils.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/utils.py Outdated Show resolved Hide resolved
@rerowep rerowep force-pushed the wep-user-token branch 2 times, most recently from 77d602c to fe94474 Compare January 17, 2024 08:00
jma
jma requested changes Jan 23, 2024
View reviewed changes
rero_ils/modules/imports/serializers/serializers.py Outdated Show resolved Hide resolved
scripts/setup Outdated Show resolved Hide resolved
scripts/setup Outdated Show resolved Hide resolved
tests/api/documents/test_documents_rest.py Outdated Show resolved Hide resolved
tests/api/item_types/test_item_types_rest.py Show resolved Hide resolved
tests/api/items/test_items_rest.py Show resolved Hide resolved
tests/api/libraries/test_libraries_rest.py Show resolved Hide resolved
@rerowep rerowep requested a review from jma January 23, 2024 16:30
lauren-d
lauren-d requested changes Jan 24, 2024
View reviewed changes
rero_ils/modules/selfcheck/utils.py Outdated Show resolved Hide resolved
rero_ils/modules/selfcheck/utils.py Outdated Show resolved Hide resolved
@rerowep
user: create token cli
6db1b4f 
* Deletes obsolete code for user token creation.
* Replaces all string format functions with f strings.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep requested a review from lauren-d January 24, 2024 07:06
@rerowep rerowep merged commit b633854 into rero:staging Jan 24, 2024
4 checks passed
@rerowep rerowep deleted the wep-user-token branch January 31, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

@PascalRepond PascalRepond Awaiting requested review from PascalRepond

Assignees

@rerowep rerowep

Labels
developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rerowep @Garfield-fr @jma @lauren-d