pricing stats: fix number of ill requests #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PascalRepond
commented
Oct 24, 2023
PascalRepond
commented
- Fix the count of number of ILL request to be coherent with RERO+'s pricing criteria. All ILL requests created within the timeframe except those with the status "denied" are counted.
- The calculation is simplified and does not use operation logs, which created problems.
github-actions
bot
added
the
f: statistics
rerowep
approved these changes
Oct 24, 2023
PascalRepond
force-pushed
the
rep-fix-ill-stat
branch
2 times, most recently
from
613136c to
3249ca5
Compare
* Fixes the count of number of ILL request to be coherent with RERO+'s pricing criteria. All ILL requests created within the timeframe except those with the status "denied" are counted. * The calculation is simplified and does not use operation logs, which created problems. * Fixes tests. Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond
force-pushed
the
rep-fix-ill-stat
branch
from
3249ca5 to
eded3d3
Compare
lauren-d
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.