serializers: fix error when no bf:Publication
#3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalRepond
force-pushed
the
rep-fix-inventory-export
branch
from
c45b40d to
176e3f7
Compare
zannkukai
reviewed
Oct 18, 2022
PascalRepond
force-pushed
the
rep-fix-inventory-export
branch
2 times, most recently
from
f1e66b0 to
ba99174
Compare
lauren-d
approved these changes
Oct 25, 2022
* When no `provisionActivity` of type `bf:publication` is present, the collector returns None rather than an empty generator. * Fixes RT 412. * Fixes Sentry RERO-ILS-2D1. Co-Authored-by: Pascal Repond <[email protected]> Co-Authored-by: Renaud Michotte <[email protected]>
PascalRepond
force-pushed
the
rep-fix-inventory-export
branch
from
ba99174 to
8bb1b73
Compare
zannkukai
approved these changes
Oct 26, 2022
Comment on lines
+149
to
+152
| if any( | ||
| (provision_activity := prov).get('type' == 'bf:Publication') | ||
| for prov in data.get('provisionActivity', []) | ||
| ): |
There was a problem hiding this comment.
First time I see this structure ! Nice 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provisionActivityof typebf:publicationis present, the collector returns None rather than an empty generator.Co-Authored-by: Pascal Repond [email protected]
Co-Authored-by: Renaud Michotte [email protected]