Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Sentry support #310

Merged
merged 1 commit into from
May 23, 2019
Merged

config: Sentry support #310

merged 1 commit into from
May 23, 2019

Conversation

jma
Copy link
Contributor

@jma jma commented May 22, 2019

Signed-off-by: Johnny Mariéthoz [email protected]

@jma jma force-pushed the maj-sentry branch 2 times, most recently from d4f4419 to 28cce99 Compare May 22, 2019 12:29
iGormilhit
iGormilhit approved these changes May 22, 2019
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pre-approval, since Travis is red... 😉

@jma
config: Sentry support
bd4e74d 
* NEW Added minial sentry configuration and dependencies.

Signed-off-by: Johnny Mariéthoz <[email protected]>
@rerowep
Copy link
Contributor

rerowep commented May 22, 2019

We have a test_ping do we need a test_error?

@jma jma changed the title WIP config: Sentry support config: Sentry support May 23, 2019
@jma jma merged commit 39f75d5 into rero:dev May 23, 2019
@jma jma deleted the maj-sentry branch June 18, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jma @rerowep @iGormilhit